Add dependencies for import types #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Fixup PR is DefinitelyTyped/DefinitelyTyped#44092 |
sandersn
requested changes
Sep 24, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
One minor style request before I merge.
| } | ||
|
|
||
| default: | ||
| ts.forEachChild(node, recur); |
Member
There was a problem hiding this comment.
this seems pretty reasonable; I bet performance is (1) a lot worse (2) not noticeably worse.
We should keep an eye on large packages just in case.
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Contributor
Author
|
I just tested DefinitelyTyped/DefinitelyTyped#44092 locally, on top of DefinitelyTyped HEAD, and marked it ready for review. It's ready to merge as soon as this change is released. |
Member
|
I'll merge/ship/merge tomorrow morning (PDT) so that I have all day to respond to problems. |
sandersn
approved these changes
Sep 25, 2020
Member
|
This is done now. |
sandersn
pushed a commit
that referenced
this pull request
Nov 29, 2021
Add 'no-single-element-tuple-type' rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/types-publisher#767
Fixes #35
Fixes #47